smart-amp-test: Use module API for all memory allocations #10378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use module API mod_zalloc() for memory allocation and mod_data_blob_handler_new() for blob handler allocation and corresponding module API functions for freeing them. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the smart_amp_test_ipc4 module to use the module API for all memory allocations and deallocations, replacing legacy memory management functions with their module-aware equivalents.
- Replaces
rzalloc()withmod_zalloc()for struct allocation - Replaces
comp_data_blob_handler_new()withmod_data_blob_handler_new()for blob handler creation - Replaces corresponding free functions with their module API equivalents
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lgirdwood
approved these changes
Nov 21, 2025
kv2019i
approved these changes
Nov 21, 2025
lyakh
approved these changes
Nov 24, 2025
softwarecki
approved these changes
Nov 26, 2025
Collaborator
softwarecki
left a comment
softwarecki
left a comment
There was a problem hiding this comment.
I see a new function mod_zalloc :)
Member
|
@lrudyX good to merge, not sure if this test is run on internal CI ? |
No, it is not run. Only set and get are validated with CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use module API mod_zalloc() for memory allocation and mod_data_blob_handler_new() for blob handler allocation and corresponding module API functions for freeing them.